Confirmation for changing theme #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealharshit
changed the title
|
@therealharshit i think this feels somewhat outdated stuff actually directly changing the theme is pretty nice so dont think it must be changed well lets see what everyone suggest |
Since changing of theme requires a refresh I think users should get an alert before the refresh. |
seems well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the theme changes without giving a confirmation and refresh the browser.
I have added a confirmation message for theme change,
vedio:
theme-confirmation.mp4
on clicking the text message the browser refresh and new theme is applied.
@walterbender we have the same workflow for changing the language, so I thought we should also have that kind of workflow for changing the theme.
Please review.