Merge pull request #1232 from sul-dlss/linked-series-wo-links

Do not attempt to link nil link values in MARC series data

app/views/marc_fields/_linked_series.html.erb

@@ -1,6 +1,9 @@
 <dt><%= linked_series.label %></dt>
 <% linked_series.values.each do |series| %>
   <dd>
-    <%= link_to(series[:link].strip, catalog_index_path(q: "\"#{series[:link].strip}\"", search_field: 'search_series')) %> <%= series[:extra_text] %>
+    <% if series[:link] %>
+      <%= link_to(series[:link].strip, catalog_index_path(q: "\"#{series[:link].strip}\"", search_field: 'search_series')) %>
+    <% end %>
+    <%= series[:extra_text] %>
   </dd>
 <% end %>

spec/views/marc_fields/_linked_series.html.erb_spec.rb

@@ -33,6 +33,22 @@
   end
 
   it 'included the extra text after the link' do
-    expect(subject).to have_css('dd', text: 'The Link Value Some other text')
+    expect(subject).to have_css('dd', text: /The Link Value\s+Some other text/)
+  end
+
+  context 'when a link is not present' do
+    let(:linked_series) do
+      double(
+        'LinkedSeries',
+        label: 'Series',
+        values: [
+          { extra_text: 'Some other text' }
+        ]
+      )
+    end
+
+    it 'successfully renders just the extra text' do
+      expect(subject).to have_css('dd', text: 'Some other text')
+    end
   end
 end