Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author and visibility #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

carakas
Copy link
Contributor

@carakas carakas commented Feb 22, 2018

No description provided.

@carakas carakas requested a review from a team February 22, 2018 09:45
@Sellato
Copy link
Contributor

Sellato commented Mar 6, 2018

Error in file src/Backend/Modules/Quotes/Installer/Data/install.sql

extra comma at line 7
+ `author` varchar(255) NOT NULL DEFAULT '',,

please replace with

+ `author` varchar(255) NOT NULL DEFAULT '',

=================
In file src/Frontend/Modules/Quotes/Layout/Templates/Quote.html.twig
it will be better to use author + name - {{ quote.author }} {{ quote.name }}

  <blockquote>
    <div class="row align-items-center">
      {% if quote.image %}
        <div class="col-2">
          <img src="{{ quote.imageDirectoryUrl }}/x150/{{ quote.image }}" alt="{{ quote.author }} {{ quote.name }}" class="img-responsive">
        </div>
      {% endif %}
      <div class="{% if quote.image %} col-10{% else %} col-12{% endif %}">
        {{ quote.quote|raw }}
        <cite>{{ quote.author }} {{ quote.name }}</cite>
      </div>
    </div>
  </blockquote>
{% endmacro %}```

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants