Fix name of opcache reset file for deployer #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name changed going from capistrano to deployer
tijsverkoyen
requested changes
Mar 26, 2024
| @@ -42,7 +42,7 @@ deny from env=stayout | |||
| RewriteRule src/Backend/Core/Js/ckfinder/core/connector/php/connector\.php - [L] | |||
|
|
|||
| # allow the php-opcache-reset.php file | |||
| RewriteRule ^php-opcache-reset\.php - [L] | |||
| RewriteRule ^php-opcache_reset\.php - [L] | |||
There was a problem hiding this comment.
Why? Wouldn't it make a lot more sense to fix the filename? With this change it is a mix of - en _
There was a problem hiding this comment.
I was thinking about backwards compatibility, changing the name in deployer would break sites where the .htaccess already was correct. But that is probably nowhere the case, so fixing it in deployer makes indeed more sense.
There was a problem hiding this comment.
Closed in favor of tijsverkoyen/deployer-sumo#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the correct file in .htaccess.
The name changed going from capistrano to deployer.
See: https://github.com/tijsverkoyen/deployer-sumo/blob/b07c4853a06909fcea4d6bc9ba25b740c0752689/recipe/opcache.php#L9
Type