chore: favor eslint-webpack-plugin

BREAKING CHANGE: config/rules-linter.js is now gone.
sunlin0oo · Jan 10, 2022 · c3a4205 · c3a4205
1 parent de08163
commit c3a4205
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/Utilities/ExampleRunner/template-config.js b/Utilities/ExampleRunner/template-config.js
@@ -12,15 +12,17 @@ module.exports = function buildConfig(
   exampleBasePath
 ) {
   return `
-var rules = [].concat(require('../config/rules-vtk.js'), require('../config/rules-examples.js'), require('../config/rules-linter.js'));
+var rules = [].concat(require('../config/rules-vtk.js'), require('../config/rules-examples.js'));
 var HtmlWebpackPlugin = require('html-webpack-plugin');
+var ESLintPlugin = require('eslint-webpack-plugin');
 var webpack = require('webpack');
 var path = require('path');
 
 module.exports = {
   mode: 'development',
   devtool: 'inline-source-map',
   plugins: [
+    new ESLintPlugin(),
     new HtmlWebpackPlugin({
       template: '${root.replace(
         /\\/g,

diff --git a/Utilities/config/rules-linter.js b/Utilities/config/rules-linter.js
diff --git a/karma.conf.js b/karma.conf.js
@@ -3,7 +3,7 @@ const path = require('path');
 
 const webpack = require('webpack');
 const testsRules = require('./Utilities/config/rules-tests');
-const linterRules = require('./Utilities/config/rules-linter');
+const ESLintPlugin = require('eslint-webpack-plugin');
 
 const sourcePath = path.join(__dirname, './Sources');
 
@@ -37,7 +37,7 @@ module.exports = function init(config) {
     webpack: {
       mode: 'development',
       module: {
-        rules: [].concat(testsRules, linterRules),
+        rules: [].concat(testsRules),
       },
       resolve: {
         modules: [path.resolve(__dirname, 'node_modules'), sourcePath],
@@ -52,6 +52,7 @@ module.exports = function init(config) {
         },
       },
       plugins: [
+	new ESLintPlugin(),
         new webpack.DefinePlugin({
           __BASE_PATH__: "'/base'",
         }),