Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort contexts before listing them #1016

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

yardenshoham
Copy link
Contributor

It was annoying to have a different order for the context every time I ran kubecm switch

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.

It was annoying to have a different order for the context every time I ran `kubecm switch`

Signed-off-by: Yarden Shoham <[email protected]>
Copy link

the-label-bot bot commented Oct 26, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 20.03%. Comparing base (21244ba) to head (dbfe8fd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/utils.go 0.00% 2 Missing ⚠️
cmd/delete.go 0.00% 1 Missing ⚠️
cmd/export.go 0.00% 1 Missing ⚠️
cmd/rename.go 0.00% 1 Missing ⚠️
cmd/switch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   20.68%   20.03%   -0.66%     
==========================================
  Files          21       21              
  Lines        2185     2601     +416     
==========================================
+ Hits          452      521      +69     
- Misses       1686     2033     +347     
  Partials       47       47              
Flag Coverage Δ
unittests 20.03% <0.00%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunny0826 sunny0826 self-assigned this Nov 1, 2024
@sunny0826 sunny0826 added the kind/feature ategorizes issue or PR as related to a new feature. label Nov 1, 2024
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆

@sunny0826 sunny0826 merged commit aa50f46 into sunny0826:master Nov 1, 2024
6 checks passed
@yardenshoham yardenshoham deleted the sort branch November 1, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants