-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix noaccess retries #12
base: main
Are you sure you want to change the base?
Conversation
@sunsided At the moment this change will stop every process that exited with status code 1. I'm working on recoverable errors now but I think it should be another pull request |
@@ -251,13 +251,19 @@ fn start_output_loop_thread(out_rx: Receiver<ChildEvent>) -> JoinHandle<()> { | |||
"{id}: Process exited with {} - will retry in {}", | |||
status, delay | |||
); | |||
} else { | |||
} else if delay == RetryDelay::NONE { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the newly added if statement here is either unnecessary or incorrect. Unnecessary because positive delay times are already captured above, incorrect because it leaves out the hypothetical negative delay times ("less that NONE"). What was the reason for adding it?
@pophilpo The restarting is integral to the functionality. If a pod is temporarily unreachable (e.g. due to a rolling update or scale-down event), we need the connection to be retried. |
This PR will implement breaking out of the thread loop if the exit code of the
port-forward
call is 1 (#11). Before breaking out it will send aChildEvent::Exit
with a newRestartPolicy::NEVER