fix: set the otp if it's not a test otp (#1223)

## What kind of change does this PR introduce? * OTP should be test if not using the test OTP --------- Co-authored-by: Stojan Dimitrovski <[email protected]>
supabase · Aug 17, 2023 · 3afc8a9 · 3afc8a9
1 parent 4ff1fe0
commit 3afc8a9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/internal/api/phone.go b/internal/api/phone.go
@@ -75,14 +75,15 @@ func (a *API) sendPhoneConfirmation(ctx context.Context, tx *storage.Connection,
 	now := time.Now()
 
 	var otp, messageID string
+	var err error
 
 	if testOTP, ok := config.Sms.GetTestOTP(phone, now); ok {
 		otp = testOTP
 		messageID = "test-otp"
 	}
 
 	if otp == "" { // not using test OTPs
-		otp, err := crypto.GenerateOtp(config.Sms.OtpLength)
+		otp, err = crypto.GenerateOtp(config.Sms.OtpLength)
 		if err != nil {
 			return "", internalServerError("error generating otp").WithInternalError(err)
 		}

diff --git a/internal/api/verify_test.go b/internal/api/verify_test.go
@@ -353,7 +353,9 @@ func (ts *VerifyTestSuite) TestInvalidOtp() {
 		},
 	}
 
-	for _, c := range cases {
+	for _, caseItem := range cases {
+		c := caseItem
+
 		ts.Run(c.desc, func() {
 			// update token sent time
 			sentTime = time.Now()
@@ -904,7 +906,8 @@ func (ts *VerifyTestSuite) TestVerifyValidOtp() {
 		},
 	}
 
-	for _, c := range cases {
+	for _, caseItem := range cases {
+		c := caseItem
 		ts.Run(c.desc, func() {
 			// create user
 			u.ConfirmationSentAt = &c.sentTime