feat: use template/text instead of strings.Replace for phone OTP messages
#1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Jul 22, 2023
hf
reviewed
Jul 22, 2023
hf
changed the title
template/text instead of strings.Replace for phone OTP messages
hf
reviewed
Aug 2, 2023
hf
reviewed
Aug 3, 2023
hf
approved these changes
Aug 3, 2023
|
🎉 This PR is included in version 2.91.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
As per microtask, refactors the way in which we generate the sms message template.
Cautionary note: if merged, an error will be thrown if a Key other than Code is placed into the SMS template (e.g.
Your code is {{ .Code}} and {{ .SomeOtherKey}}) and an attempt to send SMS is made. While users hopefully do not have such templates we will need to update the FE input to guard agains thisUpd: We did a quick check and found no such entries on the hosted platform