Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop string cast on withDefault #1193

Merged
merged 1 commit into from
Jul 21, 2023
Merged

refactor: drop string cast on withDefault #1193

merged 1 commit into from
Jul 21, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jul 20, 2023

What kind of change does this PR introduce?

withDefault returns a string, so cast isn't strictly needed

@J0 J0 requested a review from a team as a code owner July 20, 2023 20:30
@J0 J0 merged commit 5bb5db2 into master Jul 21, 2023
1 check passed
@J0 J0 deleted the j0/remove_string_cast branch July 21, 2023 08:35
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.84.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants