fix: unescape escaped special characters in subject header #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
changed the title
|
Closing, refer to internal notion for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, the Supabase config file escapes special characters wherever present. This PR aims to unescape given special characters. Since the primary character of contention seems to be the apostrophe
'we escape this character. While this fix seems to work, it seems rather hacky as the issue it resolves is somewaht specific to the Supabase hosted setupWhat is the current behavior?
Emails are sent with ' wherever there is a '. For example, John's email becomes John's Email
What is the new behavior?
John's email remains as John's email. Tested on a hosted Supabase instance with
'inserted