Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add provider ID to session #1239

Closed
wants to merge 1 commit into from
Closed

Conversation

hf
Copy link
Contributor

@hf hf commented Sep 1, 2023

Adds the provider ID to a session, encoding the provider which was used to initially issue the session.

This allows developers to:

  • Revoke sessions issued by a potentially insecure provider.
  • Allow us to track the provider in audit logs.
  • In the coming Session Control API, it will allow developers to show their users how that session was initially established.

@hf hf requested a review from a team as a code owner September 1, 2023 17:09
Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hf why is this necessary?

@hf
Copy link
Contributor Author

hf commented Oct 9, 2023

@kangmingtay It helps us identify which session was issued by which provider. This allows developers to:

  1. Revoke sessions issued by a potentially insecure provider.
  2. Allow us to track the provider in audit logs.
  3. In the coming Session Control API, it will allow developers to show their users how that session was initially established.

@kangmingtay
Copy link
Member

@hf the auth.identities table also stores information about a provider. Given that a session is created from one of the user's identity, we can probably associate the identity id to the session.

I would prefer to have a single source of truth for the provider rather than storing this information in the auth.identities table and auth.sessions table

@hf hf closed this Mar 11, 2024
@hf hf deleted the hf/add-provider-id-to-session branch March 11, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants