Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: external host validation #1808

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: external host validation #1808

merged 1 commit into from
Oct 22, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Oct 22, 2024

Adds a new config option GOTRUE_MAILER_EXTERNAL_HOSTS that serves as an allowlist to all the acceptable hosts provided to the APIs.

Fixes #1228

@hf hf requested a review from a team as a code owner October 22, 2024 08:55
@hf hf merged commit 4f6a461 into master Oct 22, 2024
3 checks passed
@hf hf deleted the hf/external-host-validation branch October 22, 2024 09:01
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Merged
hf pushed a commit that referenced this pull request Oct 22, 2024
@github-actions
chore(master): release 2.163.1 (#1809)
39459c1 
🤖 I have created a release *beep* *boop*
---


##
[2.163.1](v2.163.0...v2.163.1)
(2024-10-22)


### Bug Fixes

* external host validation
([#1808](#1808))
([4f6a461](4f6a461)),
closes [#1228](#1228)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11456724364

Details

  • 51 of 54 (94.44%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 57.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/middleware.go 51 54 94.44%
Files with Coverage Reduction New Missed Lines %
internal/api/middleware.go 1 80.99%
Totals Coverage Status
Change from base Build 11351205156: 0.1%
Covered Lines: 9570
Relevant Lines: 16742
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Invitation Links - http://kong is the domain
3 participants
@hf @coveralls @kangmingtay