ci: upload release artifact to supabase s3 bucket #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/artifact-bucket
branch
from
b411ce3
to
2a2724a
Compare
Pull Request Test Coverage Report for Build 11467779604Details
💛 - Coveralls |
J0
approved these changes
Oct 23, 2024
kangmingtay
reviewed
Oct 30, 2024
Comment on lines
+93
to
+98
| - name: configure aws credentials for uploading release artifacts | ||
| uses: aws-actions/configure-aws-credentials@v1 | ||
| with: | ||
| role-to-assume: ${{ secrets.PROD_AWS_ROLE }} | ||
| aws-region: us-east-1 | ||
|
|
There was a problem hiding this comment.
we only upload the release artifacts when the release-please PR is merged and not the rc versions right? seems like this would push every rc to s3 since the action is also triggered on the release/* branch
kangmingtay
reviewed
Nov 5, 2024
| @@ -126,6 +132,8 @@ jobs: | |||
| -f "sha=$GITHUB_SHA" | |||
| fi | |||
| fi | |||
|
|
|||
| aws s3api put-object --bucket ${{ secrets.PROD_ARTIFACTS_BUCKET }} --key auth-v$RELEASE_VERSION-arm64.tar.gz --body ./auth-v$RELEASE_VERSION-arm64.tar.gz | |||
There was a problem hiding this comment.
added PROD_ARTIFACTS_BUCKET this to the repo secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads the release artifact to a Supabase owned S3 bucket for easy releases.