Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error messaging for http hooks #1821

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • HTTP hooks that return status codes outside of the accepted status codes will cause Auth to return an obscure error message that is hard to debug: Error executing Hook - this change is an attempt to improve the error messaging to reflect the status code being rejected

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@kangmingtay kangmingtay requested a review from a team as a code owner October 28, 2024 13:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11555372765

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.16%

Totals Coverage Status
Change from base Build 11551246852: 0.0%
Covered Lines: 9564
Relevant Lines: 16732

💛 - Coveralls

@kangmingtay kangmingtay merged commit fa020d0 into master Oct 28, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-auth-hook-error branch October 28, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants