Add information to JWT about enabled MFA's, allowing to enforce aal2 only if 2FA is enabled on user's account
#1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the JWT consumer (e.g. if JWT is passed to some other API which verifies its authenticity) can only enforce 2FA AAL levels once 2FA is enabled. This allows to enforce 2FA only when at least one factor is used making 2FA roll-out optional.
tomekit
changed the title
aal2 only if 2FA is enabled on user's account
Pull Request Test Coverage Report for Build 11589790641Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
J0
reviewed
Nov 2, 2024
| @@ -309,6 +309,15 @@ func (a *API) generateAccessToken(r *http.Request, tx *storage.Connection, user | |||
| issuedAt := time.Now().UTC() | |||
| expiresAt := issuedAt.Add(time.Second * time.Duration(config.JWT.Exp)).Unix() | |||
|
|
|||
| atLeastOneVerifiedFactor := false | |||
| for i := 0; i < len(user.Factors); i++ { | |||
There was a problem hiding this comment.
Thanks for the contribution! There's a user.HasMFAEnabled() function I believe. Can consider using that . Otherwise no objections to this change - I think there might be some internal configuration we use to track claim additions, we will need to update that before merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Supabase team,
This is to satisfy setup in which
supabase/authgenereated JWT can be passed to external API which validates JWT validity on its own. With this change the external API can determine whether to enforceaal2level or not, based onhas_factorboolean which determines if user has at least one verified factor.Commit description:
Please let me know if you would be happy to merge that into your codebase.