-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exclude supabase managed schemas from inspect subcommand #2138
Conversation
Pull Request Test Coverage Report for Build 8665741536Details
💛 - Coveralls |
76428d5
to
867bc75
Compare
867bc75
to
931ee66
Compare
931ee66
to
c3c4312
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more comment. Everything else looks good.
859216a
to
03c5f18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified all commands locally and fixed the result types where appropriate.
A new change I made is to include managed schemas like auth, storage, extensions, etc. when inspecting table sizes, ie. table-records-count
, table-sizes
, total-table-sizes
. Because records in these schemas are mostly inserted by the user, it would be a good idea to surface their sizes. Schemas with pg_*
prefix and information_schema
are still excluded from these queries.
In the future, we can perhaps move queries.go to individual *.sql
files for better syntax checks.
What kind of change does this PR introduce?
Feature/Fix: moving queries for inspect to the root
inspect
module and removing Supabase schemas from queriesWhat is the current behavior?
Queries are within the command and show results from Supabase schemas that could cause concern or make the user take actions on schemas they do not own
What is the new behavior?
cache-hit
command and a column explains whether action might be neededAdditional context