feat: Option to create Edge Functions with JavaScript syntax #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laktek
force-pushed
the
support-js-for-functions
branch
from
1852017
to
fa9f71e
Compare
Pull Request Test Coverage Report for Build 11319321701Details
💛 - Coveralls |
| return err | ||
| } | ||
| // update config | ||
| if err := utils.InitConfig(utils.InitParams{EdgeRuntimeDefaultLanguage: choice.Summary, Overwrite: true}, fsys); err != nil { |
There was a problem hiding this comment.
reminder to self: support in-place config update to unblock this functions use case
|
Will revisit this after we have support to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds the option to create, serve, and deploy pure JS functions instead of using TypeScript.
Users can set
EdgeRuntime.default_languageto either JavaScript or TypeScript to set the language template they want to use. This can be overridden withlangflag when usingfunctions new.functions serveandfunctions deploywill now treat for bothindex.jsandindex.tsas valid entrypoints.