Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor let api decide for restart #2835

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

avallete
Copy link
Member

@avallete avallete commented Nov 5, 2024

What kind of change does this PR introduce?

Following: https://github.com/supabase/infrastructure/pull/20462

Let the api decide if the service restart is necessary.

caution
Deduplicating the logic remove our ability to log a message to the user but since we didn't allowed to act on it (agree / refute) I think it's alright to let the API be the source of truth.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11687034984

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.775%

Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11677870651: -0.06%
Covered Lines: 6372
Relevant Lines: 10660

💛 - Coveralls

@sweatybridge sweatybridge merged commit cc62b3c into develop Nov 6, 2024
13 checks passed
@sweatybridge sweatybridge deleted the chore/use-api-restart branch November 6, 2024 08:46
@sweatybridge
Copy link
Contributor

The other change that we want to do on the worker side is to trigger SIGUP on the database to apply the new config when not restarting https://supabase.slack.com/archives/C02FHG9QQAF/p1729925142614479?thread_ts=1728485737.099679&cid=C02FHG9QQAF

@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants