Skip to content

Commit

Permalink
feat: bump node to 18
Browse files Browse the repository at this point in the history
  • Loading branch information
soedirgo committed Sep 18, 2023
1 parent 3514106 commit a11bae5
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "16"
node-version: "18"

- run: |
npm clean-install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "16"
node-version: "18"

- run: |
npm clean-install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:

jobs:
publish:
# Must match glibc verison in node:16-bullseye
runs-on: ubuntu-20.04
# Must match glibc verison in node:18
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -15,7 +15,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- run: npm i
- run: npm run binary:build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- run: |
npm clean-install
Expand All @@ -43,7 +43,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Prepare release
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16-bullseye as build
FROM node:18 as build
WORKDIR /usr/src/app
# Do `npm ci` separately so we can cache `node_modules`
# https://nodejs.org/en/docs/guides/nodejs-docker-webapp/
Expand All @@ -7,7 +7,7 @@ RUN npm clean-install
COPY . .
RUN npm run build && npm prune --omit=dev

FROM node:16-bullseye-slim
FROM node:18-slim
WORKDIR /usr/src/app
COPY --from=build /usr/src/app/node_modules node_modules
COPY --from=build /usr/src/app/dist dist
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"test:update": "run-s db:clean db:run && node --experimental-vm-modules node_modules/jest/bin/jest.js --runInBand --updateSnapshot && run-s db:clean"
},
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
},
"jest": {
Expand Down Expand Up @@ -75,7 +75,7 @@
"devDependencies": {
"@types/crypto-js": "^4.1.1",
"@types/jest": "^29.2.4",
"@types/node": "^16.18.3",
"@types/node": "^18.17.17",
"@types/pg": "^8.6.5",
"@types/pg-format": "^1.0.1",
"@types/prettier": "^2.7.3",
Expand Down

0 comments on commit a11bae5

Please sign in to comment.