Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typegen): swift generator #790

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(typegen): swift generator #790

merged 2 commits into from
Jul 2, 2024

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jul 1, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

  • Swift generator doesn't support properties that start with _, which is a valid Swift identifier
  • Swift keywords used as property names must be escaped using `

@grdsdev grdsdev requested review from a team as code owners July 1, 2024 18:48
@grdsdev grdsdev mentioned this pull request Jul 1, 2024
Closed
@grdsdev grdsdev merged commit f39902d into master Jul 2, 2024
4 checks passed
@grdsdev grdsdev deleted the fix/swift-generator branch July 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grdsdev @soedirgo