Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional configuration options for dns #3151

Merged
merged 1 commit into from
Jan 5, 2024
Merged

add additional configuration options for dns #3151

merged 1 commit into from
Jan 5, 2024

Conversation

senyosimpson
Copy link
Member

Change Summary

What and Why:

Add the ability to configure the resolv.conf file. Can specify additional nameservers, searches and options.

How:

Adds the relevant fields to the machine configuration

Related to:

Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

jsierles
jsierles approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@jsierles jsierles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these types are used elsewhere, as they aren't being used in this PR.

@senyosimpson
Copy link
Member Author

I'm assuming these types are used elsewhere, as they aren't being used in this PR.

Yep!

@senyosimpson senyosimpson merged commit 3816c82 into master Jan 5, 2024
43 checks passed
@senyosimpson senyosimpson deleted the dns-config branch January 5, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsierles jsierles jsierles approved these changes

@jipperinbham jipperinbham Awaiting requested review from jipperinbham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senyosimpson @jsierles