Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP service & network to ip list #3279

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

michaeldwan
Copy link
Contributor

@michaeldwan michaeldwan commented Feb 13, 2024

This PR includes a service name and network of an IP address if available. Private ipv6 addresses grant access to the network an IP was created in, so it's important to show this so users understand why an IP exists and what access it provides. See the docs for more.

Before:

fly ips list
VERSION	IP                	TYPE   	REGION	CREATED AT        
v6     	fdaa:0:33:0:1::10 	private	global	Oct 31 2023 14:47	
v6     	fdaa:0:35:0:1::a  	private	global	Oct 27 2023 20:43	
v6     	fdaa:2:d67:0:1::3 	private	global	Dec 4 2023 16:57 	
v6     	fdaa:3:8c8f:0:1::2	private	global	Nov 13 2023 21:24

After

fly ips list
VERSION	IP                	TYPE   	REGION	NETWORK               	SERVICE	CREATED AT        
v6     	fdaa:0:33:0:1::10 	private	global	fly/default           	       	Oct 31 2023 14:47	
v6     	fdaa:0:35:0:1::a  	private	global	flyio-ui/default      	       	Oct 27 2023 20:43	
v6     	fdaa:2:d67:0:1::3 	private	global	flyctl-backend/default	       	Dec 4 2023 16:57 	
v6     	fdaa:3:8c8f:0:1::2	private	global	balloon-popper/default	       	Nov 13 2023 21:24

Don't merge until a PR against rails is deployed!

@michaeldwan michaeldwan marked this pull request as draft February 13, 2024 19:46
@michaeldwan michaeldwan marked this pull request as ready for review February 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants