Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sftp for custom private networks #4055

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

eliferrous
Copy link
Contributor

Change Summary

What and Why:
this is referenced in our docs but wasn't included in the changes to add custom network support to flyctl in #3447

How:
copies changes to ssh/console.go to allow the agent to access the app's network

Related to:
https://github.com/superfly/flyctl/pull/3447/files

Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@eliferrous eliferrous merged commit d522500 into superfly:master Nov 11, 2024
6 checks passed
@eliferrous eliferrous deleted the sftp-fix branch November 11, 2024 21:48
Copy link

sentry-io bot commented Nov 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ *errors.errorString: failed probing "personal": context deadline exceeded github.com/superfly/flyctl/internal/sentry in C... View Issue
  • ‼️ *errors.withStack: error saving config file: open C:\Users\cuthb.fly\config.yml: Access is denied. github.com/superfly/flyctl/internal/wireguard i... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants