fix no attribute of 'depsgraph'. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujit1618
approved these changes
May 17, 2020
There was a problem hiding this comment.
Thank you so much for the fix, it works! Just FYI, it doesn't seem to have been updated to the files under this link: https://github.com/supermedium/aframe-particleplayer-component
Yeah, it hasn't shown upstream until this PR is merged. EDIT: Sorry I just noticed that you approved these changes, would you like to merge it if everything is OK for you? Then it will show upstream at that link. |
|
same issue still there for 2.8x and higher (2.9). This only working on 2.79 or lower versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix #8.
Since it's under the blender2.8 directory, I guess it's ok to use this new API directly?