-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 Custom UI Boiler Plate Code #121
Draft
ceroy-ak
wants to merge
29
commits into
supertokens:master
Choose a base branch
from
ceroy-ak:ceroy/react-custom-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt Choices for UI Build Type, like Prebuilt or Custom BREAKING CHANGE: 🧨 NO ✅ Closes: 000
Added docs for the strategies BREAKING CHANGE: 🧨 NO ✅ Closes: 000
The changes ensures that the user cannot enter unsupported set of arguments to generate the boiler plate and also the argument name is changed and code cleanup is done BREAKING CHANGE: 🧨 YES ✅ Closes: 000
ceroy-ak
changed the title
feat: 🎸 Prompt Choices for UI Build Type
feat: 🎸 Custom UI Boiler Plate Code
Oct 7, 2024
rishabhpoddar
suggested changes
Oct 7, 2024
Added initial answers for the prompt and also cleaned up the code to remove promises which are not required at the moment BREAKING CHANGE: 🧨 YES ✅ Closes: 000
React Custom UI using Vite BREAKING CHANGE: 🧨 NO ✅ Closes: 000
Removed forked github repo link BREAKING CHANGE: 🧨 NO ✅ Closes: 000
Custom React UI Components BREAKING CHANGE: 🧨 NO ✅ Closes: 000
rishabhpoddar
suggested changes
Oct 9, 2024
boilerplate/frontend/supertokens-react-custom/config/all_auth.tsx
Outdated
Show resolved
Hide resolved
Custom UI design for EmailPassword and PasswordLess. Installed tailwind and also vite port changed BREAKING CHANGE: 🧨 YES ✅ Closes: 000
Custom UI for Thirdparty BREAKING CHANGE: 🧨 YES ✅ Closes: 000
Moved the scripts to scriptUtils to avoid path calculation which may lead to potentials bugs BREAKING CHANGE: 🧨 YES ✅ Closes: 000
rishabhpoddar
suggested changes
Oct 11, 2024
boilerplate/frontend/supertokens-react-custom/src/pages/Auth/thirdparty/useSocialLogin.ts
Outdated
Show resolved
Hide resolved
...okens-react-custom/src/pages/Auth/thirdpartypasswordless/passwordless/PasswordlessSignIn.tsx
Show resolved
Hide resolved
boilerplate/frontend/supertokens-react-custom/src/config/emailpassword.tsx
Outdated
Show resolved
Hide resolved
boilerplate/frontend/supertokens-react-custom/src/hooks/useSessionInfo.ts
Outdated
Show resolved
Hide resolved
boilerplate/frontend/supertokens-react-custom/src/pages/Auth/emailpassword/useLogin.ts
Outdated
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Oct 12, 2024
boilerplate/frontend/supertokens-react-custom/src/hooks/useSessionInfo.ts
Outdated
Show resolved
Hide resolved
rishabhpoddar
suggested changes
Oct 14, 2024
@@ -0,0 +1,24 @@ | |||
# Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it looks good. But i would need the following changes before merging:
- Better styling
- Removing of "react-custom" id. We should keep frontend as react ID and use the ui type flag in our logic.
- Thorough testing cause we have changed a lot of the core CLI logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt Choices for UI Build Type, like Prebuilt or Custom
BREAKING CHANGE: 🧨 NO
✅ Closes: 000
Summary of change
A brief description of what this PR is about
Related issues
Test plan
--recipe=...
for example)--recipe=...
for example)Checklist for important updates
package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
Recipe
andallRecipes
SupportedFrontends
andallFrontends
if requiredSupportedBackends
andallBackends
if requiredRemaining TODOs for this PR