Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Custom UI Boiler Plate Code #121

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

ceroy-ak
Copy link

@ceroy-ak ceroy-ak commented Oct 7, 2024

Prompt Choices for UI Build Type, like Prebuilt or Custom

BREAKING CHANGE: 🧨 NO

✅ Closes: 000

Summary of change

A brief description of what this PR is about

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test plan

  • If added a new boilerplate
    • I tested the new boilerplate by running the CLI locally
    • I tested that the boilerplate is created and works correctly when using command line flags (--recipe=... for example)
  • If added a new recipe, frontend or backend
    • I tested that the newly added option is usable by passing command line flags (--recipe=... for example)

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If added a new recipe, I also modified types to include the new recipe in Recipe and allRecipes
  • If added a new frontend, I also modified types to include the new frontend in SupportedFrontends and allFrontends if required
  • If added a new backend, I also modified types to include the new backend in SupportedBackends and allBackends if required

Remaining TODOs for this PR

  • Item1
  • Item2

Prompt Choices for UI Build Type, like Prebuilt or Custom

BREAKING CHANGE: 🧨 NO

✅ Closes: 000
Added docs for the strategies

BREAKING CHANGE: 🧨 NO

✅ Closes: 000
The changes ensures that the user cannot enter unsupported set of
arguments to generate the boiler plate and also the argument name is
changed and code cleanup is done

BREAKING CHANGE: 🧨 YES

✅ Closes: 000
@ceroy-ak ceroy-ak changed the title feat: 🎸 Prompt Choices for UI Build Type feat: 🎸 Custom UI Boiler Plate Code Oct 7, 2024
lib/ts/config.ts Outdated Show resolved Hide resolved
lib/ts/filterChoicesUtils.ts Outdated Show resolved Hide resolved
lib/ts/filterChoicesUtils.ts Outdated Show resolved Hide resolved
lib/ts/filterChoicesUtils.ts Outdated Show resolved Hide resolved
lib/ts/filterChoicesUtils.ts Outdated Show resolved Hide resolved
lib/ts/filterChoicesUtils.ts Outdated Show resolved Hide resolved
lib/ts/userArgumentUtils.ts Outdated Show resolved Hide resolved
lib/ts/config.ts Outdated Show resolved Hide resolved
Added initial answers for the prompt and also cleaned up the code to
remove promises which are not required at the moment

BREAKING CHANGE: 🧨 YES

✅ Closes: 000
@ceroy-ak ceroy-ak marked this pull request as draft October 8, 2024 05:51
React Custom UI using Vite

BREAKING CHANGE: 🧨 NO

✅ Closes: 000
Removed forked github repo link

BREAKING CHANGE: 🧨 NO

✅ Closes: 000
Custom React UI Components

BREAKING CHANGE: 🧨 NO

✅ Closes: 000
lib/ts/config.ts Outdated Show resolved Hide resolved
lib/ts/setup-scripts/frontend/supertokens-react-custom.ts Outdated Show resolved Hide resolved
Custom UI design for EmailPassword and PasswordLess. Installed tailwind
and also vite port changed

BREAKING CHANGE: 🧨 YES

✅ Closes: 000
Custom UI for Thirdparty

BREAKING CHANGE: 🧨 YES

✅ Closes: 000
Moved the scripts to scriptUtils to avoid path calculation which may
lead to potentials bugs

BREAKING CHANGE: 🧨 YES

✅ Closes: 000
lib/ts/config.ts Outdated Show resolved Hide resolved
lib/ts/index.ts Show resolved Hide resolved
lib/ts/config.ts Outdated Show resolved Hide resolved
lib/build/filterChoicesUtils.js Outdated Show resolved Hide resolved
@@ -0,0 +1,24 @@
# Logs
Copy link
Contributor

@rishabhpoddar rishabhpoddar Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks good. But i would need the following changes before merging:

  • Better styling
  • Removing of "react-custom" id. We should keep frontend as react ID and use the ui type flag in our logic.
  • Thorough testing cause we have changed a lot of the core CLI logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants