feat: koa integration #123
Conversation
…ll of them when selecting backends
Bijit-Mondal
force-pushed
the
feat/koa
branch
from
04b6027
to
4a09207
Compare
lib/ts/config.ts
Outdated
| (flags.frontend !== undefined && flags.frontend.startsWith("next")) || | ||
| (answers.frontend !== undefined && answers.frontend.startsWith("next")) | ||
| ) { | ||
| // This means that they want to use nextjs fullstack |
There was a problem hiding this comment.
what about other types of fe like astro / remix etc?
There was a problem hiding this comment.
is this checking required? I had give this checking because it was also in backendPython, but as we are checking
near line no 586
return !shouldSkipBackendQuestion(answers, flags);will skip backend question if it is full-stack
There was a problem hiding this comment.
It works functionally with that code however the code needs to be better organised so that the flow is simpler.
Essentially, the backend frameworks should be part of the backend object so that if the user selects the node option, the code picks up the nested options from that object directly instead of keeping another one called NodeJSFrameworks etc.
There was a problem hiding this comment.
I was wrong problem will occur when someone will run something like
npx create-supertokens-app --appname=my-app --recipe=emailpassword --frontend=remix --backend=python it will ask for which backend framework in python , but for --frontend=next the option to choose backend framework will not come, updating..
There was a problem hiding this comment.
Hi @rishabhpoddar please re-review
lib/ts/types.ts
Outdated
| id: "koa", | ||
| }, | ||
| { | ||
| id: "express", |
There was a problem hiding this comment.
we need to have two levels of ids here. The backend should just have node, and then there should be a nodeframework thing which will have koa, express, nest. I know that python one doesnt work this way, but we need to do this correctly.
There was a problem hiding this comment.
Done. Check if it is the structure we need?
There was a problem hiding this comment.
It looks good to me.
There was a problem hiding this comment.
Hi @rishabhpoddar is this the structure we wanted?
…edOnFlags due to allBackend structure change;
Summary of change
Added Koa to the backend framework list.
Checklist for important updates
package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyRecipeandallRecipesSupportedBackendsandallBackendsif required