Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ssrSessionExists to SessionAuthForNextJS #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

porcellus
Copy link
Contributor

Summary of change

Add ssrSessionExists to SessionAuthForNextJS

Related issues

Test plan

  • If added a new boilerplate
    • I tested the new boilerplate by running the CLI locally
    • I tested that the boilerplate is created and works correctly when using command line flags (--recipe=... for example)
  • If added a new recipe, frontend or backend
    • I tested that the newly added option is usable by passing command line flags (--recipe=... for example)

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If added a new recipe, I also modified types to include the new recipe in Recipe and allRecipes
  • If added a new frontend, I also modified types to include the new frontend in SupportedFrontends and allFrontends if required
  • If added a new backend, I also modified types to include the new backend in SupportedBackends and allBackends if required

@@ -21,14 +21,14 @@ export async function HomePage() {
}

if (hasInvalidClaims) {
return <SessionAuthForNextJS />;
return <SessionAuthForNextJS ssrSessionExists={false} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, the session exists here, it's just that the claims are invalid. So the prop's name ssrSessionExists doesn't fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants