-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onChange called when the readOnly option gets changed with a value update #504
Comments
@christiangrothaus I don't think there is something about |
When updating the value of the editor programmatically and changing it to read only at the same time the |
@suren-atoyan I also encountered this issue. It appears that when the Editor's https://codesandbox.io/p/sandbox/quirky-glitter-kvhjqm?file=%2Fsrc%2FApp.tsx I have also created a PR (#605) for this fix. Please review it. |
@togo5 If this PR is merged, it will result in a big breakChange, which is even harder to accept |
Describe the bug
Updating the value of the readOnly option while also updating the value programmatically causes onChange to be called.
To Reproduce
I linked a working example below.
https://codesandbox.io/s/cool-spence-ps2dwx?file=/src/App.js
Expected behavior
I would expect onChange not to be called.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: