fix: Prevent onChange from firing when updating value in readOnly mode #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #504
As mentioned in the Issue, this is a fix for the bug where updating the
value
triggersonChange
when the Editor'sreadOnly
is set totrue
.Specifically, I limited the triggering of onChange by setting
preventTriggerChangeEvent.current = true;
even when readOnly is true.