Add overflow: hidden to the default wrapper styles #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's obviously just a proposal - I've worked around my problem using
wrapperClassName
prop.I can't find a strong argument against adding this - maybe you would have one. It seems to me that this is the expected behavior in the vast majority of scenarios. In fact, I don't think that anything in the editor itself can actually overflow this container... but Monaco creates a fixed-size element that gets resized based on this wrapper and the internal
ResizeObserver
. This makes certain layouts (like specific grids) break when resizing the viewport because the wrapper doesn't always change its size with that. The fixed-size element inside might cause the grid cell to stretch beyond what has been "reserved" for it - this SO answer contains more details about the behavior: https://stackoverflow.com/questions/43311943/prevent-content-from-expanding-grid-items/43312314#43312314So it seems to me that this shouldn't actually break any usage in the wild while making certain grid layouts (and flex ones as well) working better out of the box.