Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add react 19 to peer deps #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add react 19 to peer deps #651

wants to merge 1 commit into from

Conversation

shadowoff09
Copy link

This PR:

Adds React 19 to peer reps for the monaco-react package

@suren-atoyan
Copy link
Owner

React 19 is still in beta; I think it would be better to wait for it to be fully released, then test it and make adjustments if needed, and only then support it. wdyt?

@shadowoff09
Copy link
Author

React 19 is still in beta; I think it would be better to wait for it to be fully released, then test it and make adjustments if needed, and only then support it. wdyt?

Yes I agree, other libraries already support React 19, so I was thinking if you could merge my PR to support React 19, but you are right, we should wait.

@Johnhersh
Copy link

Came here looking for this. NextJS 15 is not an RC but it does use React19RC. This means upgrading to NextJS15 fails because of this

@shadowoff09
Copy link
Author

Came here looking for this. NextJS 15 is not an RC but it does use React19RC. This means upgrading to NextJS15 fails because of this

Exactly, its the only dependency failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadowoff09 @suren-atoyan @Johnhersh