Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks on submodules, arm builds, etc #1440

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

baconpaul
Copy link
Contributor

  1. clap-wrapper and sst-plugininfra go to head
  2. MSVC builds go to unity builds for timeliness
  3. Add "Free and Open Source" to the clap tag

1. clap-wrapper and sst-plugininfra go to head
2. MSVC builds go to unity builds for timeliness
3. Add "Free and Open Source" to the clap tag
@mkruselj
Copy link
Collaborator

mkruselj commented Oct 31, 2024

Wouldn't it make more sense if "Free" and "Open Source" were two separate tags?

@baconpaul baconpaul merged commit 3f5db41 into surge-synthesizer:main Oct 31, 2024
13 checks passed
@baconpaul baconpaul deleted the tweaks branch October 31, 2024 15:08
@baconpaul
Copy link
Contributor Author

Wouldn't it make more sense if "Free" and "Open Source" were two separate tags?

I actually thought about this, but "FOSS" -> "Free and Open Source Software" is sort of an atomic thing.

But we can add "Open Source" if we want as another one.

@baconpaul
Copy link
Contributor Author

(The primary reason I added the tags was to test the new auv2 tag export mechanism we added to the wrapper though. We can tag with whatever we want really)

@mkruselj
Copy link
Collaborator

mkruselj commented Nov 1, 2024

The way I think about this is that it doesn't make sense to have three tags (free, os, free and os) when you can AND the tag filter terms, if any host ever implements that sort of plugin filtering by tags they report. So, FOSS as a tag is not atomic enough IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants