Clamp noise tilt (#148)

surge-synthesizer · Oct 15, 2024 · 221cf0c · 221cf0c
1 parent 7610ffa
commit 221cf0c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/include/sst/voice-effects/eq/TiltEQ.h b/include/sst/voice-effects/eq/TiltEQ.h
@@ -73,7 +73,8 @@ template <typename VFXConfig> struct TiltEQ : core::VoiceEffectTemplateBase<VFXC
     void setCoeffs()
     {
         float freq = 440 * this->note_to_pitch_ignoring_tuning(this->getFloatParam(fpFreq));
-        float slope = this->getFloatParam(fpTilt) / 2;
+        float slope = std::clamp(this->getFloatParam(fpTilt), -18, 18) / 2;
+
         float posGain = this->dbToLinear(slope);
         float negGain = this->dbToLinear(-1 * slope);
         float res = .07f;

diff --git a/include/sst/voice-effects/generator/TiltNoise.h b/include/sst/voice-effects/generator/TiltNoise.h
@@ -96,7 +96,7 @@ template <typename VFXConfig> struct TiltNoise : core::VoiceEffectTemplateBase<V
 
     void setCoeffs()
     {
-        float slope = this->getFloatParam(fpTilt) / 2;
+        float slope = std::clamp(this->getFloatParam(fpTilt), -3, 3) / 2;
         float posGain = this->dbToLinear(slope);
         float negGain = this->dbToLinear(-1 * slope);
         float res = .07f;

diff --git a/include/sst/voice-effects/modulation/NoiseAM.h b/include/sst/voice-effects/modulation/NoiseAM.h
@@ -111,7 +111,7 @@ template <typename VFXConfig> struct NoiseAM : core::VoiceEffectTemplateBase<VFX
 
     void setCoeffs()
     {
-        float slope = this->getFloatParam(fpTilt) / 2;
+        float slope = std::clamp(this->getFloatParam(fpTilt), -3, 3) / 2;
         float posGain = this->dbToLinear(slope);
         float negGain = this->dbToLinear(-1 * slope);
         float res = .07f;