Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary asserts #88

Merged
merged 2 commits into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.10)
project(sst-effects VERSION 0.5 LANGUAGES C CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 20)

add_library(${PROJECT_NAME} INTERFACE)
target_include_directories(${PROJECT_NAME} INTERFACE include)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/delay/Microgate.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ template <typename VFXConfig> struct MicroGate : core::VoiceEffectTemplateBase<V

basic_blocks::params::ParamMetaData paramAt(uint16_t idx) const
{
assert(idx >= 0 && idx < (int)MicroGateParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((MicroGateParams)idx)
Expand Down
2 changes: 0 additions & 2 deletions include/sst/voice-effects/delay/StringResonator.h
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ template <typename VFXConfig> struct StringResonator : core::VoiceEffectTemplate
basic_blocks::params::ParamMetaData intParamAt(int idx) const
{
using pmd = basic_blocks::params::ParamMetaData;

assert(numIntParams == 3);
switch (idx)
{
case ipStereo:
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/distortion/BitCrusher.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ template <typename VFXConfig> struct BitCrusher : core::VoiceEffectTemplateBase<

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < bc_num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((bc_fparams)idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/eq/EqNBandParametric.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ struct EqNBandParametric : core::VoiceEffectTemplateBase<VFXConfig>

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

int type = idx % 3;
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/eq/MorphEQ.h
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ template <typename VFXConfig> struct MorphEQ : core::VoiceEffectTemplateBase<VFX

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/filter/CytomicSVF.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ template <typename VFXConfig> struct CytomicSVF : core::VoiceEffectTemplateBase<

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/filter/SSTFilters.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ template <typename VFXConfig> struct SSTFilters : core::VoiceEffectTemplateBase<

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
177 changes: 0 additions & 177 deletions include/sst/voice-effects/filter/Slewer.h

This file was deleted.

3 changes: 0 additions & 3 deletions include/sst/voice-effects/filter/StaticPhaser.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ template <typename VFXConfig> struct StaticPhaser : core::VoiceEffectTemplateBas
basic_blocks::params::ParamMetaData intParamAt(int idx) const
{
using pmd = basic_blocks::params::ParamMetaData;

assert(numIntParams == 2);
switch (idx)
{
case ipStages:
Expand All @@ -92,7 +90,6 @@ template <typename VFXConfig> struct StaticPhaser : core::VoiceEffectTemplateBas

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/filter/SurgeBiquads.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ template <typename VFXConfig> struct SurgeBiquads : core::VoiceEffectTemplateBas

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/generator/GenPulseSync.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ template <typename VFXConfig> struct GenPulseSync : core::VoiceEffectTemplateBas

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)GenPulseSyncFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;
/*
tune,
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/generator/GenSaw.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ template <typename VFXConfig> struct GenSaw : core::VoiceEffectTemplateBase<VFXC

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)GenSawFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((GenSawFloatParams)idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/generator/GenSin.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ template <typename VFXConfig> struct GenSin : core::VoiceEffectTemplateBase<VFXC

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)GenSinFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((GenSinFloatParams)idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/modulation/FreqShiftMod.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ template <typename VFXConfig> struct FreqShiftMod : core::VoiceEffectTemplateBas

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)FreqShiftModFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((FreqShiftModFloatParams)idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/modulation/PhaseMod.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ template <typename VFXConfig> struct PhaseMod : core::VoiceEffectTemplateBase<VF

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)PhaseModFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((PhaseModFloatParams)idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/modulation/RingMod.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ template <typename VFXConfig> struct RingMod : core::VoiceEffectTemplateBase<VFX

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < numFloatParams);
using pmd = basic_blocks::params::ParamMetaData;

switch (idx)
Expand Down
1 change: 0 additions & 1 deletion include/sst/voice-effects/waveshaper/WaveShaper.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ template <typename VFXConfig> struct WaveShaper : core::VoiceEffectTemplateBase<

basic_blocks::params::ParamMetaData paramAt(int idx) const
{
assert(idx >= 0 && idx < (int)WaveShaperFloatParams::num_params);
using pmd = basic_blocks::params::ParamMetaData;

switch ((WaveShaperFloatParams)idx)
Expand Down
Loading