Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up the Digital RingMod oversample latency to 8 #965

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Up the Digital RingMod oversample latency to 8 #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ec5dd1
Up the Digital RingMod oversample latency to 8
baconpaul Dec 8, 2023
e3d0eaf
Clang Format
baconpaul Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/nightlychangelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 2.2.0
## 2.2.1

### New Modules
- Bonsai
Expand Down Expand Up @@ -47,4 +47,5 @@
newly added channel in a high gate situation.
- Rework the LFOxEG gate behavior so the code is less confusing.
As a result, fix a bug where the envelope would mis-trigger when
both GATE and GATEENV were connected.
both GATE and GATEENV were connected.
- VCO Character, Level and Drift don't participate in randomization
8 changes: 4 additions & 4 deletions src/DigitalRingMod.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,12 @@ struct DigitalRingMod : modules::XTModule,

std::array<std::array<std::unique_ptr<sst::filters::HalfRate::HalfRateFilter>, MAX_POLY>, 2>
halfbandInA, halfbandInB, halfbandOut;
static constexpr int blockSize{4}, blockSizeOS{blockSize << 1};
float inputA[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
static constexpr int blockSize{8}, blockSizeOS{blockSize << 1};
float inputA alignas(16)[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
bool aMono[2]{false, false};
float inputB[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
float inputB alignas(16)[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
bool bMono[2]{false, false};
float output[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
float output alignas(16)[2][MAX_POLY][2][blockSize]; // 0,1; poly; L/R
int blockPos{0};
int poly[2]{1, 1};
};
Expand Down
6 changes: 3 additions & 3 deletions src/VCO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ struct VCO : public modules::XTModule, sst::rackhelpers::module_connector::Neigh
configParamNoRand(RETRIGGER_STYLE, 0, 1, 0, "Random Phase on Retrigger");
configParamNoRand(EXTEND_UNISON, 0, 1, 0, "Extend Unison");
configParamNoRand(ABSOLUTE_UNISON, 0, 1, 0, "Absolute Unison");
configParam(CHARACTER, 0, 2, 1, "Character Filter");
configParam(DRIFT, 0, 1, 0, "Oscillator Drift", "%", 0, 100);
configParam(FIXED_ATTENUATION, 0, 1, 1, "Output Level", "%", 0, 100);
configParamNoRand(CHARACTER, 0, 2, 1, "Character Filter");
configParamNoRand(DRIFT, 0, 1, 0, "Oscillator Drift", "%", 0, 100);
configParamNoRand(FIXED_ATTENUATION, 0, 1, 1, "Output Level", "%", 0, 100);

VCOConfig<oscType>::configureVCOSpecificParameters(this);
config_osc->~Oscillator();
Expand Down