New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use -fno-char8_t on regular builds #994

Merged

baconpaul merged 1 commit into surge-synthesizer:main from CardinalModules:dont-use-no-char8-t

Mar 10, 2024

Contributor

falkTX commented Mar 10, 2024

There is still a -fno-char8_t in place which breaks builds with GCC7, which can be removed since a few lines above we have:

if (CMAKE_CXX_STANDARD GREATER_EQUAL 20)
  message(STATUS "Turning on fno-char8_t for c++20")
  add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-fno-char8_t>)
endif()


          Do not use -fno-char8_t on regular builds

21307b8

Signed-off-by: falkTX <[email protected]>

baconpaul merged commit 4e0c376 into surge-synthesizer:main

8 checks passed

falkTX deleted the dont-use-no-char8-t branch

March 10, 2024 15:27

baconpaul mentioned this pull request

Change log out-of-date #1017

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet