fix with boolean.

susom · Apr 14, 2023 · 7d6999d · 7d6999d
1 parent 515c588
commit 7d6999d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/OnCoreIntegration.php b/OnCoreIntegration.php
@@ -626,8 +626,8 @@ public function injectIntegrationUI($project_irb)
             "oncore_integrations"       => $integrations,
             "has_oncore_integration"    => $this->hasOnCoreIntegration() ,
             "has_field_mappings"        => !empty($this->getMapping()->getProjectFieldMappings()['pull']) && !empty($this->getMapping()->getProjectFieldMappings()['push']) ? true : false ,
-            "last_adjudication"         => $last_adjudication,
-            "matching_library"          => $matching_library
+            "last_adjudication" => $last_adjudication,
+            "matching_library" => $matching_library
         );
 
         $aa = ($this->escape(json_encode($notifs_config)));
@@ -641,6 +641,7 @@ public function injectIntegrationUI($project_irb)
             $(function () {
                 const module = <?=$this->getJavascriptModuleObjectName()?>;
                 module.config = decode_object("<?=$this->escape(json_encode($notifs_config))?>");
+                console.log(module.config)
                 module.afterRender(<?=$this->getJavascriptModuleObjectName()?>.InitFunction);
             })
         </script>

diff --git a/assets/scripts/oncore.js b/assets/scripts/oncore.js
@@ -11,7 +11,10 @@ function decode_object(obj) {
             if (typeof parsedObj[key] === 'object') {
                 parsedObj[key] = decode_object(parsedObj[key])
             } else {
-                parsedObj[key] = decode_string(parsedObj[key])
+                // ignore boolean because changing them to string will cause error.
+                if (typeof parsedObj[key] != 'boolean') {
+                    parsedObj[key] = decode_string(parsedObj[key])
+                }
             }
         }
         return parsedObj