Skip to content

Commit

Permalink
fix(exporter): do no enable estimated idle power by default (#276)
Browse files Browse the repository at this point in the history
The 'idle' value refers to the total host idle power, which is not
distributed among all the running VMs on the node. Consequently, each
VM may wrongly double-count the host's idle time if there are multiple
VMs on the same host.

In public cloud environments, it is impractical to determine the
number of running VMs on a node. This parameter is intended for use
only one bare metal servers that rely on node power estimation because
they do not provide real-time power metrics, or when there is only
one VM running on the host for very specific scenarios.

So, lets enable this setting through Kepler spec (new feature).

Ref: sustainable-computing-io/kepler#973 (comment)

Signed-off-by: Sunil Thaha <[email protected]>
  • Loading branch information
sthaha authored Oct 13, 2023
1 parent d8cb5e4 commit d3f7eba
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/components/exporter/exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ func NewDaemonSet(detail components.Detail, k *v1alpha1.Kepler) *appsv1.DaemonSe
"/usr/bin/kepler",
"-address", bindAddress,
"-enable-cgroup-id=true",
"-expose-estimated-idle-power=true",
"-enable-gpu=$(ENABLE_GPU)",
"-v=$(KEPLER_LOG_LEVEL)",
"-kernel-source-dir=/usr/share/kepler/kernel_sources",
Expand Down

0 comments on commit d3f7eba

Please sign in to comment.