-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): migrate mock-acpi workflow to GH runner #1882
chore(ci): migrate mock-acpi workflow to GH runner #1882
Conversation
🤖 SeineSailor Here's a concise summary of the pull request changes: Summary: This PR migrates the mock-acpi workflow from an Equinix self-hosted runner to a GitHub runner, enabling consistent ACPI functionality validation for Kepler on every pull request. Key Modifications:
Impact: This change may affect the external interface and behavior of the code, particularly in how validation results are handled. No changes are observed in global data structures, variables, or exported function signatures, except for the modified Suggestions:
|
768a155
to
d329d6f
Compare
The existing mock-acpi workflow file and ansible code can kept as they will be reused when adding #1834 |
- name: Wait for services to be ready | ||
run: | | ||
echo "Waiting for services to start..." | ||
sleep 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from robust part of view, can we make a timeout? as a loop with condition to wait for compose up and timeout break as failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, it should be warm-up time for Kepler to start producing metrics. I have updated this step
This commit migrates the mock-acpi workflow to use the GitHub runner instead of the Equinix self-hosted runner. Since the workflow is designed for testing ACPI functionality, using a mock, a self-hosted runner is not required. Running the workflow on the GitHub runner, which operates as a VM, enables execution on every pull request, ensuring consistent validation of ACPI functionality for Kepler. Signed-off-by: vprashar2929 <[email protected]>
d329d6f
to
182ba81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from CI part of view.
This commit migrates the mock-acpi workflow to use the GitHub runner instead of the Equinix self-hosted runner. Since the workflow is designed for testing ACPI functionality, using a mock, a self-hosted runner is not required.
Running the workflow on the GitHub runner, which operates as a VM, enables execution on every pull request, ensuring consistent validation of ACPI functionality for Kepler.