Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): migrate mock-acpi workflow to GH runner #1882

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

vprashar2929
Copy link
Collaborator

This commit migrates the mock-acpi workflow to use the GitHub runner instead of the Equinix self-hosted runner. Since the workflow is designed for testing ACPI functionality, using a mock, a self-hosted runner is not required.

Running the workflow on the GitHub runner, which operates as a VM, enables execution on every pull request, ensuring consistent validation of ACPI functionality for Kepler.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: This PR migrates the mock-acpi workflow from an Equinix self-hosted runner to a GitHub runner, enabling consistent ACPI functionality validation for Kepler on every pull request.

Key Modifications:

  1. Return type change: The validate_acpi function's return type is changed from int to None, with an Exit exception raised instead to indicate validation results.
  2. Import addition: The Exit exception is imported from the click.exceptions module.

Impact: This change may affect the external interface and behavior of the code, particularly in how validation results are handled. No changes are observed in global data structures, variables, or exported function signatures, except for the modified validate_acpi function.

Suggestions:

  • Consider adding tests to ensure the new Exit exception handling behaves as expected.
  • Review the calling code to ensure it's prepared to handle the changed return type and exception behavior of validate_acpi.
  • Verify that the GitHub runner migration doesn't introduce any unexpected side effects or performance changes.

@vprashar2929
Copy link
Collaborator Author

vprashar2929 commented Dec 4, 2024

The existing mock-acpi workflow file and ansible code can kept as they will be reused when adding #1834

- name: Wait for services to be ready
run: |
echo "Waiting for services to start..."
sleep 60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from robust part of view, can we make a timeout? as a loop with condition to wait for compose up and timeout break as failure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it should be warm-up time for Kepler to start producing metrics. I have updated this step

This commit migrates the mock-acpi workflow to use the
GitHub runner instead of the Equinix self-hosted runner.
Since the workflow is designed for testing ACPI functionality,
using a mock, a self-hosted runner is not required.

Running the workflow on the GitHub runner, which operates as a VM,
enables execution on every pull request, ensuring consistent validation
of ACPI functionality for Kepler.

Signed-off-by: vprashar2929 <[email protected]>
Copy link
Collaborator

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from CI part of view.

@vprashar2929 vprashar2929 merged commit 8ab7ff8 into sustainable-computing-io:main Dec 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants