-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for @requires and @member #36
Conversation
Hey @lemori, thanks for contributing! i am not really following the removal of jsdoc3-parser and the use of the outer jsdoc module. Is there a particular use case that prompted this move? |
funny, I was just looking at it too. I don't think requiring people to install jsdoc3-parser to use jsdox is desirable. If there's a use case for using a more recent version, or a custom version, then make it an option so people can use the global one, or the one at a specific path. And what are the enhancements? Can you provide some details? |
@psq Unless I'm misunderstanding, it sounds like a request for accepting piped input into the jsdox binary. Where you could do:
Additionally, we should support:
And if To avoid hijacking this PR, we should consider moving this discussion into a separate issue if you'd like. |
@mrjoelkemp both use cases you outline above make sense, and if we can't easily detect there is an input, we can add a command line option (for the first use case). But if there is no parsed input, or a parser provided, I'd use the internal one. A separate PR would work better indeed. |
@mrjoelkemp Hello! jsdox is great, but it failed to run again on my win7, and I can't find out why it crashed(the error message was useless for me). So...it is hijacking:(
Probably I had misused the function of fork? I'll revert the codes. Thanks for your advice:) |
@psq I added requires:
members:
It's only for one doc each time, and it may be buggy. It's only for testing right now and not ready to merge. |
Somehow, jsdox works fine today. I've reverted some codes and can focus on layout now. UPDATE: It supports directory parsing. |
{{#params}} | ||
**{{name}}**: {{#typesString}}{{typesString}}, {{/typesString}}{{#description}}{{{description}}}{{/description}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrjoelkemp looks like we need that way to customize the templates rather sooner than later.
Hey @lemori. Thanks again for your work. You've given us the motivation to tackle a few important features:
The only aspect of this PR that is mergeable is the addition of Thanks again for your hard work. Also, feel free to tackle any of the aforementioned issues; we'd love the help in making JSDox more configurable. |
@mrjoelkemp +1 |
@mrjoelkemp It's no bad to make a contribution! I modifies Great features to come and I'll try to realize #38 |
@mrjoelkemp I realized #38 in new PR(#41), you could merge the later if it's OK. |
I've renamed the pull request to better describe what the latest code is doing now. But I could not get requires to show up in the output, so do you think you could add a new file in the fixtures directory to demonstrate usage of the 2 new tags? |
I don't know how to create a fixture file, though there are some samples. |
It is easy. Add a file here: https://github.com/sutoiku/jsdox/tree/master/fixtures, and commit the result output here https://github.com/sutoiku/jsdox/tree/master/sample_output with
|
Added fixture |
yes, something like that. I'll double check as soon as practical, but it looks like I should be able to merge that in. Will let you know. |
@lemori now that @mrjoelkemp added travis support, would you mind doing a dummy push (like adding a space or empty line) so we can check the tests with travis (assuming you merge again with master, that is) |
@psq done. |
@lemori You have a jshint error that's failing the build:
Single line
|
@mrjoelkemp I was wondering that. It's OK now. |
requires
andmembers
fields.Reference: jsdoc documents
USAGE
Will be parsed as: