Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change Base Labels to CamelCase for ArgoCD ApplicationSets Compatibility #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Change Base Labels to CamelCase for ArgoCD ApplicationSets Compatibility #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bb069b
Update base labels
Jan 16, 2025
a58ec0d
Update cluster-secret
Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/template/cluster-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: "usercluster-{{ .UserCluster.ID }}" # Changing this will result in a recreate of the secret
labels:
argocd.argoproj.io/secret-type: cluster
"{{ .BaseLabel }}/managed": "true" # You should not change this atm, required to clean up clusters when they dont exist
"{{ .BaseLabel }}/cluster-id": "{{ .UserCluster.ID }}" # You should not change this atm
"{{ .BaseLabel }}/seed": "{{ .UserCluster.Seed.Name }}" # You should not change this atm
"{{ .BaseLabel }}Managed": "true" # You should not change this atm, required to clean up clusters when they dont exist
"{{ .BaseLabel }}ClusterId": "{{ .UserCluster.ID }}" # You should not change this atm
"{{ .BaseLabel }}Seed": "{{ .UserCluster.Seed.Name }}" # You should not change this atm

# Some examples for composed values
#kkp-seed: "{{ .UserCluster.Seed.Name }}"
Expand Down
10 changes: 5 additions & 5 deletions pkg/argo_connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ import (
)

const (
BASE_LABEL string = "kubermatic-argocd-bridge"
TIMEOUT_START_LABEL = BASE_LABEL + "/timeout-start"
MANAGED_LABEL = BASE_LABEL + "/managed"
CLUSTER_ID_LABEL = BASE_LABEL + "/cluster-id"
SEED_LABEL = BASE_LABEL + "/seed"
BASE_LABEL string = "KubermaticArgocdBridge"
TIMEOUT_START_LABEL = BASE_LABEL + "TimeoutStart"
MANAGED_LABEL = BASE_LABEL + "Managed"
CLUSTER_ID_LABEL = BASE_LABEL + "ClusterId"
SEED_LABEL = BASE_LABEL + "Seed"
ARGO_CLUSTER_LABEL string = "argocd.argoproj.io/secret-type=cluster"
)

Expand Down
Loading