-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable Globals #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2d4637 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant update, but no breaking changes to the library, focusing on making global objects like
window
,document
, andnavigator
configurable. This allows for better flexibility and testing capabilities.Configurable Globals:
ConfigurableWindow
,ConfigurableDocument
,ConfigurableDocumentOrShadowRoot
,ConfigurableNavigator
, andConfigurableLocation
to allow custom global objects.BROWSER
).Utility Functions and Classes:
AnimationFrames:
AnimationFrames
class to accept a configurablewindow
object and use it forrequestAnimationFrame
andcancelAnimationFrame
.ElementRect:
ElementRect
class to accept a configurablewindow
object and use it inuseResizeObserver
anduseMutationObserver
.ElementSize:
ElementSize
class to accept a configurablewindow
object and use it forResizeObserver
.IsFocusWithin:
IsFocusWithin
class to accept configurabledocument
andwindow
objects and use a newuseActiveElement
utility.IsIdle:
IsIdle
class to accept configurabledocument
andwindow
objects and use them for event listeners and visibility change detection.Testing:
These changes improve the flexibility and testability of Runed by allowing custom global objects to be used in various utilities and classes.
Closes #167