Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try goccy/go-json #14

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Try goccy/go-json #14

wants to merge 4 commits into from

Conversation

vearutop
Copy link
Member

No description provided.

@goccy
Copy link

goccy commented Feb 15, 2021

Hi ! I've fixed this problem with v0.4.5 !

@github-actions
Copy link

Benchmark Result

Benchmark diff with base branch
>> using vendor
name                        old time/op    new time/op    delta
Schema_UnmarshalJSON_raw-2    99.1µs ± 2%    97.8µs ± 6%     ~     (p=0.421 n=5+5)
Schema_UnmarshalJSON-2         780µs ± 1%     348µs ± 5%  -55.41%  (p=0.008 n=5+5)
Schema_MarshalJSON_raw-2       111µs ± 1%      60µs ± 2%  -45.76%  (p=0.008 n=5+5)
Schema_MarshalJSON-2           335µs ± 1%     214µs ± 3%  -36.02%  (p=0.008 n=5+5)

name                        old alloc/op   new alloc/op   delta
Schema_UnmarshalJSON_raw-2    32.3kB ± 0%    48.7kB ± 0%  +50.86%  (p=0.008 n=5+5)
Schema_UnmarshalJSON-2         191kB ± 0%     189kB ± 0%   -0.98%  (p=0.008 n=5+5)
Schema_MarshalJSON_raw-2      30.2kB ± 0%     9.9kB ± 0%  -67.08%  (p=0.008 n=5+5)
Schema_MarshalJSON-2          54.5kB ± 0%    48.4kB ± 0%  -11.24%  (p=0.008 n=5+5)

name                        old allocs/op  new allocs/op  delta
Schema_UnmarshalJSON_raw-2       461 ± 0%       720 ± 0%  +56.18%  (p=0.008 n=5+5)
Schema_UnmarshalJSON-2         2.03k ± 0%     1.62k ± 0%  -20.27%  (p=0.008 n=5+5)
Schema_MarshalJSON_raw-2         625 ± 0%        72 ± 0%  -88.48%  (p=0.008 n=5+5)
Schema_MarshalJSON-2             488 ± 0%       372 ± 0%  -23.77%  (p=0.008 n=5+5)

@github-actions
Copy link

Unit Test Coverage

total: (statements) 68.5%

Coverage diff with base branch
15c15
< github.com/swaggest/jsonschema-go/date.go	UnmarshalJSON	100.0%
---
> github.com/swaggest/jsonschema-go/date.go	UnmarshalJSON	80.0%
130c130
< total:	(statements)	68.7%
---
> total:	(statements)	68.5%

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #14 (9e859f0) into master (41a3c17) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   63.61%   63.38%   -0.24%     
==========================================
  Files           6        6              
  Lines         863      863              
==========================================
- Hits          549      547       -2     
- Misses        259      260       +1     
- Partials       55       56       +1     
Flag Coverage Δ
unittests 63.38% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
date.go 83.33% <ø> (-16.67%) ⬇️
entities.go 49.08% <ø> (ø)
helper.go 82.41% <ø> (ø)
reflect.go 71.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a3c17...8d54019. Read the comment docs.

@vearutop
Copy link
Member Author

Thank you, works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants