Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Game CatchTheBall #1660

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Conversation

shruti110503
Copy link
Contributor

@shruti110503 shruti110503 commented Jun 4, 2024

Added the game successfully.

πŸ› οΈ Closes #1609

πŸ‘¨β€πŸ’» Changes proposed and Brief Description

I have added the game as proposed. It is made using html css and javascript.

βœ… Check List (Check all the applicable boxes)

  • [ βœ“] My code doesn't break any part of the project
  • [ βœ“] This PR does not contain plagiarized content.
  • [βœ“ ] My Addition/Changes works properly and matches the overall repo pattern.
  • [ βœ“] The title of my pull request is a short description of the requested changes.
    catch-the-ball

πŸ“· Screenshots

Copy link

netlify bot commented Jun 4, 2024

βœ… Deploy Preview for 30daysofjs ready!

Name Link
πŸ”¨ Latest commit f9a8f00
πŸ” Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/6675c2ed481fe700086abb44
😎 Deploy Preview https://deploy-preview-1660--30daysofjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your project in index.html

index.html Outdated
<h4>CatchTheBall</h4>
<p>Catch the ball on the rolling pad and beat your own highscore!</p>
<a href="117 - CatchTheBall"><button class="button">Live</button></a>
<a href="http://127.0.0.1:5500/117-CatchTheBall/index.html"><button class="button">Github</button></a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be you localhost url, update this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swapnilsparsh can you please help me as to how can i add my own localhost url

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shruti110503 Take reference from the other url which are there in the index.htm and make the required changes

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict and still the URL is not right.

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict and add your project in index.html also

Copy link
Owner

@swapnilsparsh swapnilsparsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the bugs:

  1. When game is over and you play again then the slider is not working properly.
  2. When clicking on left button then the slider keeps on going left if I am pressing right button.

@swapnilsparsh
Copy link
Owner

@shruti110503 Not working on mobile

@swapnilsparsh
Copy link
Owner

@shruti110503 Any updates ?

@shruti110503
Copy link
Contributor Author

@shruti110503 Any updates ?

please check now

@swapnilsparsh swapnilsparsh merged commit 1f06995 into swapnilsparsh:master Jun 21, 2024
4 checks passed
@swapnilsparsh
Copy link
Owner

@shruti110503 Thank you for contributing to this repo. Looking forward for more πŸš€

@swapnilsparsh swapnilsparsh added gssoc GirlScript Summer of Code 2024 level3 Hard labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code 2024 level3 Hard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title: Catch The Ball Game
2 participants