Implement surface-invalidation-v1 #51
Conversation
|
Typo in the commit message: s/invalidated/invalidation/ |
Nefsen402
force-pushed
the
surface-invalidation
branch
from
ab49f94
to
23f6dbe
Compare
Nefsen402
changed the title
| output->surface_invalidation.serial); | ||
| output->committed_width = 0; | ||
| output->committed_height = 0; | ||
| output->committed_scale = 0; |
There was a problem hiding this comment.
Hm, why do we need to reset these?
There was a problem hiding this comment.
Oh, to trigger the buffer_change bool below?
There was a problem hiding this comment.
Maybe we can add || output->surface_invalidation.needs_ack to the buffer_change condition?
There was a problem hiding this comment.
In the render loop, it will compare the old committed_state with whatever it wants to render now, If the results are the same it will simply commit and return early. This is not good enough: we need to make sure that the render_frame function goes all the way through to create a buffer and commit. Just flipping the buffer_change isn't good enough, took me a while to debug that.
| if (output->surface_invalidation.needs_ack) { | ||
| output->surface_invalidation.needs_ack = false; | ||
| wp_surface_invalidation_v1_ack(output->surface_invalidation.object, | ||
| output->surface_invalidation.serial); |
There was a problem hiding this comment.
Would be a bit nicer to move this to render_frame.
No description provided.