Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Fig1 as pdf + tuning it #35

Closed
wants to merge 6 commits into from
Closed

Fig1 as pdf + tuning it #35

wants to merge 6 commits into from

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Jul 3, 2017

I made this PR on top of gvwilson/for-submission for my own convenience.

The core commit is 2dafe68

Which is a tentative improvements of fig1

  • make it included as pdf so it is not pixelized/rasterized (generated with inkscape + ghostscript cleaning)
  • use a font that is closer (in style and size) to the paper's font
  • add some space to breathe
  • add crossroad sign (openclipart)

gvwilson and others added 6 commits June 30, 2017 10:04
- make it included as pdf so it is not pixelized/rasterized (generated with inkscape + ghostscript cleaning)
- use a font that is closer (in style and size) to the paper's font
- add some space to breathe
- add crossroad sign (openclipart)
@twitwi twitwi mentioned this pull request Jul 3, 2017
@twitwi
Copy link
Contributor Author

twitwi commented Jul 3, 2017

NB: the .png file is outdated, the paper uses the .pdf

@gvwilson
Copy link
Contributor

gvwilson commented Jul 7, 2017

There are lot of diffs now - is this worth rebasing?

@raynamharris
Copy link
Contributor

raynamharris commented Jul 7, 2017

@twitwi It looks like we both made changes to an older version of figure 1, so now your and my newest commits (#37) are in conflict.

In this conflict, I add some white space and I changed the image for the link to other resources. I do really the like direction sign, but let me know if you like the hyperlink image, since now the working of the rule is "link to other resources" rather than "point to other resources".

@twitwi
Copy link
Contributor Author

twitwi commented Jul 7, 2017

Sorry, I didn't know you worked on the figure. I'm closing this.

@twitwi twitwi closed this Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants