Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

Minor issues #46

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Minor issues #46

merged 2 commits into from
Oct 9, 2017

Conversation

ianmilligan1
Copy link
Contributor

Most of the smaller tweaks are pretty straightforward, but I did want to flag two that I had questions on. I figured others may want to tweak so I opened a Pull Request on the branch.

I wasn't entirely sure of these two ones below:

SUGGESTION: It would be useful to provide the URL in the text for rule #3 since online best practices for lesson development circles back to online collaborative lesson development.

In this case, do we think the reviewer is referring to having a link for Software Carpentry? I inserted it. In any case, Rule 3 may be redesigned in line with issue #41.

SUGGESTION: In Rule #5, it would be helpful if the authors redirected to Rule #6 when discussing recognizing contributions.

I like the division that we have in Rules 5 and 6 right now, so wasn't sure about a significant reorganization (I think that'd also unbalance the text). I thought about potentially adding a sentence like

It can also help with the formal and informal recognition of labour, discussed in the following rule.

But I don't think we need signposting when the rules are so close to each other.

See checklist, not entirely sure about tweaks to Rule #3 and #5
I don't think we need signposting in such proximity.
@ianmilligan1 ianmilligan1 mentioned this pull request Sep 27, 2017
14 tasks
@gdevenyi
Copy link
Contributor

gdevenyi commented Oct 2, 2017

Looks good.

I'm with you not needing signposting. One would hope they would read the whole document in one go, in which case its not needed.

@raynamharris raynamharris merged commit fcdfbd4 into master Oct 9, 2017
@raynamharris
Copy link
Contributor

raynamharris commented Oct 9, 2017

This looks good to me. And, As far as I can tell doesn't conflict with PR 48, so I'm going to merge

@raynamharris raynamharris deleted the minor-issues branch October 9, 2017 22:39
@ianmilligan1
Copy link
Contributor Author

Thanks for the merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants