Setup #367
Closed
Setup #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request: carpentries/styles#327
Pull Request carpentries/styles#330 Closes carpentries/styles#343 1. Fix the script so that all figures are displayed. 2. Add image numbers. 3. Don't add headers for episodes without images. 4. Add horizontal rulers to better separate adjacent images. Don't add a ruler after the last image in the episode. 5. Add empty lines to `figures.md` to improve code readability. 6. Use classes for styling text and figures
* replace page.root with 'base' variable that knows path level * deal with case of trailing / in URL * use link to figure out path for logos * simplify path building for favicons * baseurl isn't used in our template so it can removed * use 'base' variable for path root instead of unecessary http request to site.url * replace page.root with 'base' variable that knows path level * deal with case of trailing / in URL * use link to figure out path for logos * simplify path building for favicons * baseurl isn't used in our template so it can removed * use 'base' variable for path root instead of unecessary http request to site.url * rename variable, consolidate comments * rename variable in template files
Code/callout/prereq/etc blocks: set left and right margins to 0
See apple.com/macos
DOC: remove whitespace
make where in all caps
Use spaces between operators and commas
Line 230 needs a letter "a" before the word "quick", so I did the grammar modification.
Update 03-filter.md
Correct "database" to "table"
Correct "quantitative" to "quantity"
* Edit explanation of conventions for capitalization
Simplification + solution for group concatenation exercise
fixes swcarpentry#338 Co-authored-by: Jenna Jordan <[email protected]>
Primary key must be taken, person, quant
Co-authored-by: James Scott-Brown <[email protected]>
Restructure exercise
ref swcarpentry#338 Co-authored-by: Jenna Jordan <[email protected]>
Primary key commentgit status
Update explanation on new database creation
Add instructions for .sqliterc
Provide more details on table fields
Enhance the syntax to improve visualization.
❌ DANGER ❌DO NOT MERGE THIS PULL REQUESTThe fork umn-dash/sql-novice-survey@setup has divergent history and contains an invalid commit (b4fbb1fcd0f6850d57dfb6f0a136bc255ac1e900). For the Pull Request Author@nihiliad, if you want to contribute your changes, you must delete your fork and re-fork this repository. |
|
Oops! Submitted this PR by mistake. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we aren't using Software Carpentry workshop sites anymore, this moves the more detailed workshop setup instructions into this curriculum.