Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Training Loop into a Class (✓ Sandbox Passed) #157

Closed
wants to merge 4 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Nov 25, 2023

Description

This pull request refactors the training loop in the main.py file into a class called Trainer. It also updates the api.py file to use the Trainer class for loading the model and making predictions.

Summary

  • Refactored the training loop in main.py into a Trainer class
  • Updated api.py to use the Trainer class for loading the model and making predictions

Fixes #6.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Author

sweep-nightly bot commented Nov 25, 2023

Sandbox Executions

  • Ran sandbox for src/main.py. ✓
Sandbox logs for https://github.com/sweepai/evals/commit/7a0e73c7322bb5e768e759e4b59b3cdf8347b506
trunk fmt src/main.py || exit 0 1/2 ✓
 ✔ Formatted src/main.py
Re-checking autofixed files...


Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
trunk check --fix --filter=-ruff --print-failures src/main.py 2/2 ✓
Checked 1 file
✔ No issues
  • Ran sandbox for src/main.py. ✗
Run `src/main.py` through the sandbox.
  • Ran sandbox for src/api.py. ✓
Sandbox logs for https://github.com/sweepai/evals/commit/7cf31a863bab21eb403f4d15ce467e4cd8ecf888
trunk fmt src/api.py || exit 0 1/2 ✓
 ✔ Formatted src/api.py
Re-checking autofixed files...

 ✔ Formatted src/api.py
Re-checking autofixed files...


Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
trunk check --fix --filter=-ruff --print-failures src/api.py 2/2 ✓
Checked 1 file
✔ No issues

Copy link
Author

sweep-nightly bot commented Nov 25, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot added the sweep label Nov 25, 2023
@sweep-nightly sweep-nightly bot closed this Nov 25, 2023
@sweep-nightly sweep-nightly bot deleted the sweep/refactor-training-loop_26 branch November 25, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: refactor the training loop from a script to a class in main.py
0 participants